Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47191 )
Change subject: mb/purism/librem_mini: Set unused GPIO pads to PAD_NC ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 97: NONE
ack
Done
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 117: /* GPP_B11 - GPIO */ : PAD_CFG_GPO(GPP_B11, 1, PLTRST),
yup, nc, none - looks like I missed that one
Done
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 132: /* GPP_B16 - GSPI0_CLK */ : PAD_CFG_NF(GPP_B16, NONE, PLTRST, NF1),
ack. […]
Done
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 395: /* GPP_H21 - GPIO */ : PAD_CFG_GPO(GPP_H21, 0, DEEP),
ack! nc, none
Done