Attention is currently required from: Cliff Huang, Furquan Shaikh, Martin Roth, Rizwan Qureshi, Sridhar Siricilla, Bernardo Perez Priego, Andrew McRae. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55259 )
Change subject: util/cse_fpt: Add a new tool for managing Intel CSE FPT binaries ......................................................................
Patch Set 12: Verified-1
(10 comments)
File util/cbfstool/cse_fpt.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/68b6b91d_6bb9425d PS12, Line 24: bool (*match_version)(struct buffer *); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/36e28971_1cc17e2e PS12, Line 26: fpt_hdr_ptr (*read)(struct buffer *); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/bfed0690_f517f217 PS12, Line 27: void (*print)(const fpt_hdr_ptr); function definition argument 'const fpt_hdr_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/12ac63ce_2bb5177b PS12, Line 29: size_t (*get_entry_count)(const fpt_hdr_ptr); function definition argument 'const fpt_hdr_ptr' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/74248d87_0e587c04 PS12, Line 35: void read_member(struct buffer *, void *, size_t); function definition argument 'struct buffer *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/ccfc546d_3797673f PS12, Line 35: void read_member(struct buffer *, void *, size_t); function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/8964ce79_2c6bf9c7 PS12, Line 35: void read_member(struct buffer *, void *, size_t); function definition argument 'size_t' should also have an identifier name
File util/cbfstool/cse_fpt.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/c978c26a_16b7d1a8 PS12, Line 290: if (!filepath) { braces {} are not necessary for single statement blocks
File util/cbfstool/fpt_formats/fpt_hdr_20.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/c1e5bcb3_cdb60ccb PS12, Line 46: for (size_t i = 0; i < sizeof(*h); i++) { braces {} are not necessary for single statement blocks
File util/cbfstool/fpt_formats/fpt_hdr_21.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129903): https://review.coreboot.org/c/coreboot/+/55259/comment/5087dd4e_c7aacc0f PS12, Line 89: for (size_t i = 0; i < ARRAY_SIZE(h->reserved); i++) { braces {} are not necessary for single statement blocks