[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/brox: Fix booting to kernel without battery

[Sowmya Aralguppe (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Caveh Jalali, Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Keith Short, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Rishika Raj, Ronak Kanabar, Shelley Chen, Sowmya Aralguppe, Subrata Banik.

Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83752?usp=email )

Change subject: mb/google/brox: Fix booting to kernel without battery
......................................................................

Patch Set 19:

(3 comments)

File src/mainboard/google/brox/romstage.c:

https://review.coreboot.org/c/coreboot/+/83752/comment/b3065711_20e8f99f?usp... :
PS19, Line 27: MAX_NONTURBO_PERFORMANCE
> > Yes Subrata  […]

Please raise a partner issue regarding this if Boot needs to be always in HFM because by default Bootfreq is set to 2

File src/mainboard/google/brox/variants/baseboard/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83752/comment/6c9df5ce_595c36aa?usp... :
PS19, Line 57:  * PL4 calculations - For USB C charger (Max Power):
> > For PL4 writeback to work on all 3 different chargers it is required to change pl4 based on adapte […]

I am referring PL4 writeback in depthcharge not in the kernel. are you seeing any feature gap or issue with the functionality in this implementation ?

File src/mainboard/google/brox/variants/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83752/comment/8ca2c032_f498eb21?usp... :
PS19, Line 19: 		.pl1_min_power = 15000,
> > We had discussed that changes reverting psys calculations https://review.coreboot. […]
> > > > Unable to follow what is the relation between some psys revert CL

This is the CL where the PL1 limit was changed
ACK - i will raise one more Patch for pl1 value change