Attention is currently required from: Martin L Roth, Subrata Banik, Rizwan Qureshi, Krishna P Bhat D.
Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70227 )
Change subject: src/ec/intel: Create common code for board_id implementation
......................................................................
Patch Set 3:
(2 comments)
File src/ec/intel/board_id.c:
https://review.coreboot.org/c/coreboot/+/70227/comment/ddecbccc_c115c078
PS3, Line 9: BOARD_ID_INIT
i hope u plan to expand this func?
Yes, I'll be expand this as part of CB:66102
File src/mainboard/intel/mtlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/70227/comment/5bed00b6_286002a8
PS3, Line 12:
: config BOARD_SPECIFIC_OPTIONS
: def_bool y
: select EC_ACPI
please submit the separate CL for this. […]
Yes this change was part of CL: 66101 where we have the option/choice to select CHROME_EC/WINDOWS_EC. Since the option of EC_ACPI was used as part of Makefile, I thought of keeping it here and modifying it later as part of CL:66101.
Do you want me to remove this now?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70227
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If133f6a72b8c3e1d8811a11f91e4556beb8c16e0
Gerrit-Change-Number: 70227
Gerrit-PatchSet: 3
Gerrit-Owner: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Usha P
usha.p@intel.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 11:06:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment