EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46566 )
Change subject: mb/google/zork: Correct get board version and get fw config condition ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46566/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46566/1//COMMIT_MSG@9 PS1, Line 9: google_chromeec_cbi_get_board_version and google_chromeec_cbi_get_board_version
Aren't these the same function?
Done
https://review.coreboot.org/c/coreboot/+/46566/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/46566/3/src/mainboard/google/zork/v... PS3, Line 60: google_chromeec_cbi_get_fw_config(&known_value)
This CL reviewed by you as well. https://review.coreboot. […]
If you don't like this, I can remove...