Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32865 )
Change subject: device_tree: Have absolute paths start with '/'
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32865/5/src/lib/device_tree.c
File src/lib/device_tree.c:
https://review.coreboot.org/#/c/32865/5/src/lib/device_tree.c@574
PS5, Line 574: dup_path
should we add some assert to alert if path[0] is not / ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32865
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdf59ccbb4ead38c6193b630642fd1f1e847dd89
Gerrit-Change-Number: 32865
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Jun 2019 09:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment