Attention is currently required from: John Zhao, Tim Wawrzynczak, Brandon Breitenstein, Rajmohan Mani. Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48630 )
Change subject: drivers/intel/usb4: Enable retimer FW upgrade mux interaction ......................................................................
Patch Set 13:
(2 comments)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/48630/comment/27d112a8_8e9df9fa PS13, Line 109: const char *RFWU = mainboard_retimer_fw_update_path(); : : /* : * Get information to set retimer info from Arg3[0] : * Local0 = DeRefOf (Arg3[0]) : */ : acpigen_get_package_op_element(ARG3_OP, 0, LOCAL0_OP); : : /* : * Write the EC RAM for Retimer Upgrade : * RFWU = LOCAL0 : */ : acpigen_write_store(); : acpigen_emit_byte(LOCAL0_OP); : acpigen_emit_namestring(RFWU); : : /* Return (Zero) */ : acpigen_write_return_integer(0); I think we should put this entire function in the EC code, this way if the EC either doesn't implement this (empty weak function for a non-chrome design) or uses a different interface it can be supported easier.
https://review.coreboot.org/c/coreboot/+/48630/comment/e04532b3_16da20d6 PS13, Line 176: mainboard since this is intended to come from EC code, perhaps prefix with "ec_" instead of "mainboard_".