Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35639 )
Change subject: fmap: Add get_fmap_flash_offset()
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Godd catch and thanks for fixing that!
https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h
File src/include/fmap.h:
https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h@23
PS1, Line 23: int find_fmap_directory(struct region_device *fmrd);
should be unexported, now that there are no more external users.
https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h@53
PS1, Line 53: uint64_t get_fmap_flash_offset(void);
can you use fmap_locate_area_as_rdev("FMAP", ...) instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ff6e8199143d1a992a83d7de1e3b44813b733f4
Gerrit-Change-Number: 35639
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 27 Sep 2019 07:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment