mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 4:
Patch Set 4:
The original version seems to based so much on the open-source AGESA version, I couldn't really make CPU_AMD_PI_00630F01 config to work.
In any case the open-source AGESA should be the way: it could be hard to attract more AMD people to your platform if it is very blobbed. I am considering A88XME only because it has opensource AGESA and no PSP backdoor inside the CPU - security is very important to me, so I would prefer as much open-source code as possible.
Is there anything left to make this patch merged?
I haven't looked at your code yet (a bit busy with my own patches to be honest), but I think you should try to fix as many "code style" warnings as possible. Please see this message for a list - https://review.coreboot.org/c/coreboot/+/30987#message-1484ecb7bc0a5a273dcd9... .
Do you have any idea, how can I make the NIC to work? Replacing the pci route in the devicetree doesn't make any sense. The adapter remain unidentified during the boot as well.
Could you build a coreboot with a max debug level (8: SPEW), and at the fully booted system go to ./coreboot/util/cbmem/ , run "make", and then - sudo ./cbmem -c > boot.log . That's to collect the whole coreboot boot log, to see if there are any messages related to your NIC. Would be nice if you could upload such a log somewhere (pastebin?) and share with us