Attention is currently required from: Paul2 Huang, Alex1 Kao, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52936 )
Change subject: mb/google/dedede: Update pirika device tree
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/dedede/variants/pirika/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52936/comment/5a48c1b7_eca635be
PS2, Line 21: .speed_config[0] = {
: .speed = I2C_SPEED_FAST,
: .scl_lcnt = 190,
: .scl_hcnt = 100,
: .sda_hold = 40,
: }
The recommendation is to configure the measured rise_time_ns and fall_time_ns here instead of scl_lcnt and scl_hcnt. Use these lcnt/hcnt values, measure the rise_time_ns and fall_time_ns using the scope and add those measured values here.
https://review.coreboot.org/c/coreboot/+/52936/comment/0b92745e_aae6b9b9
PS2, Line 52: device domain 0 on
Prefer to split this CL into 4 parts
1) Thermal and DPTF configuration
2) Audio Configuration
3) Trackpad configuration
4) USB Camera configuration
That way it will be easy to review.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52936
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15b9cb0d0276b5e2dd06694530cc35e5643efb9d
Gerrit-Change-Number: 52936
Gerrit-PatchSet: 2
Gerrit-Owner: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kirk Wang
kirk_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ariel Chang
ariel_chang@pegatron.corp-partner.google.com
Gerrit-CC: Hao Chou
hao_chou@pegatron.corp-partner.google.com
Gerrit-CC: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Attention: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-Attention: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Tue, 11 May 2021 00:15:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment