2 Mar
2023
2 Mar
'23
8:57 p.m.
Attention is currently required from: Frank Wu, Jason Glenesk, Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Isaac Lee, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73124 )
Change subject: soc/amd/mendocino: Remove the SPL DPTC parameter ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
Why is `sustained_power_limit_mW` staying when using it is an error? […]
Hi Tim, STT usually be enabled when system has full chassis, before that, we still need to configure sustained_power_limit_mW, and it's not allowed to update its value by DPTC when STT enabled.
--
To view, visit https://review.coreboot.org/c/coreboot/+/73124
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e6dad7d24883f8aadce83ebac401ecd4137d61a
Gerrit-Change-Number: 73124
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricKY Cheng ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Isaac Lee isaaclee@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Isaac Lee isaaclee@google.com
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 Mar 2023 23:57:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu frank_wu@compal.corp-partner.google.com
Comment-In-Reply-To: Chris Wang chris.wang@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Gerrit-MessageType: comment