Attention is currently required from: Felix Singer, Maxim Polyakov, Sumeet R Pawnikar, Marvin Drees. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48648 )
Change subject: [WIP] mb/asus/sklkbl_h: Add base for Asus Skylake Boards ......................................................................
Patch Set 12:
(5 comments)
File src/mainboard/asus/sklkbl_h/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48648/comment/7a01db99_f8b13063 PS12, Line 7: register "SaGv" = "SaGv_Enabled" Only matters for ULT, remove.
https://review.coreboot.org/c/coreboot/+/48648/comment/deef2fc8_c53a9694 PS12, Line 13: register "s0ix_enable" = "1" Remove, S0ix can cause issues and only makes sense on mobile platforms anyway
File src/mainboard/asus/sklkbl_h/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/48648/comment/b0dc770b_dce82e31 PS12, Line 25: #include "acpi/dptf.asl" // TODO Is DPTF meant for desktop boards as well? I don't think so. I'd remove this and the empty file
File src/mainboard/asus/sklkbl_h/fadt.c:
https://review.coreboot.org/c/coreboot/+/48648/comment/04b4b5e0_de74bd4c PS12, Line 8: fadt->preferred_pm_profile = PM_DESKTOP; Shouldn't be needed
File src/mainboard/asus/sklkbl_h/variants/h110t/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48648/comment/4b6f9920_3652c31c PS12, Line 20: register "SendVrMbxCmd" = "2" If you copied this from another board, try without. I really doubt this applies to your board.