Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37945 )
Change subject: superio/nuvoton: add common HWM bank select function ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... File src/superio/nuvoton/common/hwm.h:
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... PS1, Line 20: //Nuvoton is a Winbond spin-off, so this code is for both
I'd use C-style comments here, or at least a space after the double slash
Done
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... File src/superio/nuvoton/common/hwm.c:
https://review.coreboot.org/c/coreboot/+/37945/1/src/superio/nuvoton/common/... PS1, Line 17: //Nuvoton is a Winbond spin-off, so this code is for both
Same
Done