Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36300/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/1/src/security/vboot/common.c... PS1, Line 131: /* TODO: We don't know the workbuf size with the current API... */
I think the comment refers to the fact that we are getting rid of workbuf_used i.e. […]
We should probably just use KERNEL_WORKBUF_RECOMMENDED_SIZE here right away, then depthcharge can just use the workbuffer from there and doesn't have to vb2api_relocate() it again. (The KERNEL_WORKBUF_RECOMMENDED_SIZE is currently still a bit large for my tastes and can be reduced, but that can wait until later. In the meantime, stealing 80K from the OS isn't gonna kill us.)