Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35752 )
Change subject: mb/*/{ms2290,x201}: Complete devicetree
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35752/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35752/1//COMMIT_MSG@11
PS1, Line 11: content.
yes, 35753 adds those ops and 35440 makes them useful by removing the romstage Function Disable writ […]
I think CB:35753 should go in first, but maybe with the commit message you currently have here. Or squash them, no strong opinions here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6ba4022b0fe4cab70964fbc08d4e9c3b4fde311
Gerrit-Change-Number: 35752
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 03 Oct 2019 08:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment