Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Though, would it make sense to draw `select RTC` into
SOC_INTEL_COMMON_PCH_BASE, too? Or even into SOC_INTEL_
COMMON_BLOCK_RTC?
https://review.coreboot.org/#/c/31102/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31102/2//COMMIT_MSG@13
PS2, Line 13: unavailable" error message gone.
Yes, you can check drivers/elog/elog. […]
Ah, my bad. I only read `cbmem` and `timestamp` and thought
it's about coreboot's timestamp feature (and cbmem showed an
error). But that'd be `-t` not `-c` ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34e73f6508bd83e2c8edf740c33eb253bffa5e6d
Gerrit-Change-Number: 31102
Gerrit-PatchSet: 3
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Jan 2019 23:31:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment