Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32651 )
Change subject: soc/amd/stoneyridge: Move GPIO support to common
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32651/2/src/mainboard/google/kahlee/mainboar...
File src/mainboard/google/kahlee/mainboard.c:
https://review.coreboot.org/#/c/32651/2/src/mainboard/google/kahlee/mainboar...
PS2, Line 30: <soc/smi.h>
:
...but seems to build OK w/o the addition.
Now I'm not sure what I was building when I made that statement. smi.h has the prototype for gpe_configure_sci() so it seems still seems necessary. The previous version of gpio.h contained #include <soc/smi.h>.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cda00210a74de2bd1308ad43e2b867d24a67845
Gerrit-Change-Number: 32651
Gerrit-PatchSet: 3
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 May 2019 18:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment