Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )
Change subject: mediatek/mt8183: modify vproc12 voltage
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33168/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33168/1//COMMIT_MSG@7
PS1, Line 7: modify vproc12 voltage
set vproc12 voltage correctly
https://review.coreboot.org/#/c/33168/1//COMMIT_MSG@9
PS1, Line 9: odify correct vproc12 register to set processor voltage.
Replace with something like this to make it more clear:
The correct address for vproc12 register is 0x1426 instead of 0x140a.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 1
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Comment-Date: Tue, 04 Jun 2019 03:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment