Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44489 )
Change subject: soc/amd/common: add GPE event logs ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44489/2/src/soc/amd/common/block/ac... File src/soc/amd/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/44489/2/src/soc/amd/common/block/ac... PS2, Line 69: if (!CONFIG(ELOG)) : return; nit: Not for this change, but I think we can drop this since elog_add_event_*() calls do the right thing depending upon whether CONFIG_ELOG is selected or not.