[coreboot-gerrit] Change in coreboot[master]: util/ifdtool: Add support for Denverton platforms.

[Name of user not set (Code Review)]

Name of user not set #1004065 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60737 )

Change subject: util/ifdtool: Add support for Denverton platforms.
......................................................................

util/ifdtool: Add support for Denverton platforms.

Signed-off-by: Jeff Daly 
Change-Id: Ie85b071201fb3f88e2c780cfb8d6a52629aa0ced
---
M util/ifdtool/ifdtool.c
M util/ifdtool/ifdtool.h
2 files changed, 30 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/60737/1

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index a6e0f8a..51b72f6 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -237,6 +237,8 @@
    	return CHIPSET_400_SERIES_ICE_POINT;
    case PLATFORM_LBG:
    	return CHIPSET_C620_SERIES_LEWISBURG;
+	case PLATFORM_DNV:
+		return CHIPSET_DENVERTON;
    default:
    	return CHIPSET_PCH_UNKNOWN;
    }
@@ -251,16 +253,17 @@
 static int is_platform_ifd_2(void)
 {
    static const int ifd_2_platforms[] = {
-		PLATFORM_APL,
-		PLATFORM_GLK,
-		PLATFORM_CNL,
-		PLATFORM_LBG,
-		PLATFORM_ICL,
-		PLATFORM_TGL,
-		PLATFORM_JSL,
-		PLATFORM_EHL,
    	PLATFORM_ADL,
+		PLATFORM_APL,
+		PLATFORM_CNL,
+		PLATFORM_DNV,
+		PLATFORM_EHL,
+		PLATFORM_GLK,
+		PLATFORM_ICL,
+		PLATFORM_JSL,
+		PLATFORM_LBG,
    	PLATFORM_SKLKBL,
+		PLATFORM_TGL,
    };
    unsigned int i;

@@ -726,6 +729,12 @@
    	(flmstr & (1 << (wr_shift + 1))) ? "enabled" : "disabled");
    printf("  Flash Descriptor Write Access:     %s\n",
    	(flmstr & (1 << wr_shift)) ? "enabled" : "disabled");
+	if (platform == PLATFORM_DNV) {
+		printf("  10GB A Region Write Access: %s\n",
+			(flmstr & (1 << (wr_shift + 11))) ? "enabled" : "disabled");
+		printf("  10GB B Region Write Access: %s\n",
+			(flmstr & (1 << (wr_shift + 12))) ? "enabled" : "disabled");
+	}

if (ifd_version >= IFD_VERSION_2)
    	printf("  EC Region Read Access:             %s\n",
@@ -741,6 +750,12 @@
    	(flmstr & (1 << (rd_shift + 1))) ? "enabled" : "disabled");
    printf("  Flash Descriptor Read Access:      %s\n",
    	(flmstr & (1 << rd_shift)) ? "enabled" : "disabled");
+	if (platform == PLATFORM_DNV) {
+		printf("  10GB A Region Read Access: %s\n",
+			(flmstr & (1 << (rd_shift + 11))) ? "enabled" : "disabled");
+		printf("  10GB B Region Read Access: %s\n",
+			(flmstr & (1 << (rd_shift + 12))) ? "enabled" : "disabled");
+	}

/* Requestor ID doesn't exist for ifd 2 */
    if (ifd_version < IFD_VERSION_2)
@@ -1639,6 +1654,7 @@
           "                                         adl    - Alder Lake\n"
           "                                         aplk   - Apollo Lake\n"
           "                                         cnl    - Cannon Lake\n"
+	       "                                         dnv    - Denverton\n"
           "                                         lbg    - Lewisburg PCH\n"
           "                                         ehl    - Elkhart Lake\n"
           "                                         glk    - Gemini Lake\n"
@@ -1895,6 +1911,8 @@
    			platform = PLATFORM_APL;
    		} else if (!strcmp(optarg, "cnl")) {
    			platform = PLATFORM_CNL;
+			} else if (!strcmp(optarg, "dnv")) {
+				platform = PLATFORM_DNV;
    		} else if (!strcmp(optarg, "lbg")) {
    			platform = PLATFORM_LBG;
    		} else if (!strcmp(optarg, "ehl")) {
diff --git a/util/ifdtool/ifdtool.h b/util/ifdtool/ifdtool.h
index 638033f..487250d 100644
--- a/util/ifdtool/ifdtool.h
+++ b/util/ifdtool/ifdtool.h
@@ -45,19 +45,21 @@
    CHIPSET_500_600_SERIES_TIGER_ALDER_POINT, /* 11th-12th gen Core i/o (LP)
    					   * variants onwards */
    CHIPSET_C620_SERIES_LEWISBURG,
+	CHIPSET_DENVERTON,
 };

enum platform {
+	PLATFORM_ADL,
    PLATFORM_APL,
    PLATFORM_CNL,
-	PLATFORM_LBG,
+	PLATFORM_DNV,
    PLATFORM_EHL,
    PLATFORM_GLK,
    PLATFORM_ICL,
    PLATFORM_JSL,
+	PLATFORM_LBG,
    PLATFORM_SKLKBL,
    PLATFORM_TGL,
-	PLATFORM_ADL,
 };

#define LAYOUT_LINELEN 80