Attention is currently required from: Jason Nien, Matt DeVillier, Jon Murphy, Martin Roth, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73250 )
Change subject: mb/google/skryim: Add RECOVERY_MRC_CACHE FMAP section
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/73250/comment/68c6ceb6_6bdef641
PS1, Line 25: RECOVERY_MRC_CACHE
would be good to have some numbers for read, write and erase speed to see if using 120k or 128k is f […]
for now, i'll submit the patch as it is and when we have data on this, this can be addressed. since the read is way more often used as an erase, i'd guess that the 120kbyte ends up saving us some small amount of time in the more common and critical paths
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73250
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f0f41c20b61c96473e887521f84f3ad240adc2b
Gerrit-Change-Number: 73250
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 27 Feb 2023 23:09:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment