Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36041 )
Change subject: drivers/gfx: Add generic graphics with SSDT generator ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36041/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36041/7//COMMIT_MSG@21 PS7, Line 21: register "device[0].privacy.detect_function" = ""\_SB.PCI0.PVSC.GPVD""
Why should you hardcode those values and not autodetect them at runtime? […]
I don't think there is anything to detect at runtime. I need a way to add privacy screen control to a LCD panel. The way in which the panel is controlled will vary between different platforms, some will control with just a GPIO others will use EC commands. So this will allow for different ACPI functions to be called depending on the platform.