Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33263 )
Change subject: Kconfig: Guard RAMPAYLOAD
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33263/1/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/#/c/33263/1/src/Kconfig@286
PS1, Line 286: HAVE_RAMPAYLOAD
I'm only afraid that if anyone !X86 tries to enable it after it might cause different failure.
So you are saying one could accidentally put a `select HAVE_RAMPAYLOAD` into
their code?
yes that was the point
But then one could also argue that ARCH_X86 could be selected by
accident, no?
:) I'm enabling Rampayload for x86 now. So it shouldn't be the problem on x86.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d158382d1000b8b40ca1368e2efff0c39884f15
Gerrit-Change-Number: 33263
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 07 Jun 2019 10:17:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment