Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46840 )
Change subject: soc/amd/picasso: Update coreboot UPD variable names to include units
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46840/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb:
https://review.coreboot.org/c/coreboot/+/46840/4/src/mainboard/google/zork/v...
PS4, Line 18: mS
The abbreviation for seconds is a lowercase s, so this should be ms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I056a76663e84ebc940343d64178c18cb20df01a3
Gerrit-Change-Number: 46840
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 27 Oct 2020 18:33:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment