Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45838 )
Change subject: soc/intel/xeon_sp/acpi: Move ACPI macros to a header file ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45838/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45838/3//COMMIT_MSG@9 PS3, Line 9: APCI
ACPI
Ack
https://review.coreboot.org/c/coreboot/+/45838/3/src/soc/intel/xeon_sp/inclu... File src/soc/intel/xeon_sp/include/soc/acpi_asl.h:
https://review.coreboot.org/c/coreboot/+/45838/3/src/soc/intel/xeon_sp/inclu... PS3, Line 47: Store (Z
old syntax. […]
nack, this patch moves code and is not a syntax code update. We don't need to arbitrarily re-write ASL code.
https://review.coreboot.org/c/coreboot/+/45838/3/src/soc/intel/xeon_sp/inclu... PS3, Line 50: ShiftLeft (1, And (^^PIR##id, ^^IREM), IRQ0)
old syntax
nack, this patch moves code and is not a syntax code update. We don't need to arbitrarily re-write ASL code.