Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37192 )
Change subject: binaryPI: Drop S3_DATA_POS and S3_DATA_SIZE
......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
Was it AGESA/binaryPI or coreboot operating on flash directly with this offset?
AGESA also has this defined.
AGESA still uses this, but like I commented earlier I will pull amd/stoneyridge implementation in to use here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37192
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I765a6084fb26398008f38c0403f808bae19fdae1
Gerrit-Change-Number: 37192
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 10:04:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment