[coreboot-gerrit] [M] Change in coreboot[main]: Documentation: Write down coreboot's git commit message rules

[Martin L Roth (Code Review)]

Attention is currently required from: Jan Samek, Nicholas Chin, Paul Menzel.

Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/75495?usp=email )

Change subject: Documentation: Write down coreboot's git commit message rules
......................................................................

Patch Set 4:

(5 comments)

File Documentation/contributing/git_commit_messages.md:

https://review.coreboot.org/c/coreboot/+/75495/comment/94fde3a5_3c785add?usp... :
PS1, Line 15: - If reflowing prose to 75 characters can reduce the length of the
            :   commit message by 2 or more lines, please reflow it.
> I understand how you feel about this, but in my opinion, it's not worth worrying about to save a sin […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/75495/comment/6852f955_dcf18e85?usp... :
PS1, Line 40: CB:XXXXX or a 10 character hash
> I understand what you're saying, but the CB:XXXXX is very convenient because jenkins turns it into a […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/75495/comment/38457d91_3c4daa41?usp... :
PS1, Line 46: - All but the most trivial of patches should generally have a body.
> Why? My opinion is that it saves people from asking why a patch was done. […]

Acknowledged

File Documentation/contributing/git_commit_messages.md:

https://review.coreboot.org/c/coreboot/+/75495/comment/0aee489e_0615f9d0?usp... :
PS3, Line 53:  TEST
> Could we also have a description for the `BUG=` tag?

Done

File Documentation/contributing/index.md:

PS3:
> Needs a rebase to match MyST Parser's toctree format

Done