Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38147 )
Change subject: soc/intel/tigerlake: Enable Audio on TGL
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38147/8/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/38147/8/src/soc/intel/tigerlake/chi...
PS8, Line 113: PchHdaIDispCodecDisconnect
Can I use IDispDisable ? if we set this to 1 in mainboard then that can translate in fsp_params. […]
Reason I asked to invert the logic is so that the mainboards that don't have to enable it can just skip setting the config in devicetree completely. If IDispDisable is added, then all mainboards that don't use it have to remember to set it to 1 to get it disconnected.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd3927a33d303ed5a663b5b838f43ed4ebc7a0db
Gerrit-Change-Number: 38147
Gerrit-PatchSet: 8
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Wed, 29 Jan 2020 06:59:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment