Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 47:
(7 comments)
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/38/src/mainboard/asus/a88xm-e... PS38, Line 39: default BOARD_ASUS_A88XM_E_DDR3_VOLT_150
BLT8G3D1869DT1TX0 isn't LP but indeed its' DDR3-1600 or DDR3-1866 might be only a part of XMP (need […]
XMP support has been successfully added to opensource AGESA ;-) Please see the topic:"AMD_XMP" changes: CB:40484 , CB:40485 , CB:40488 , CB:40489 , CB:40490 .
https://review.coreboot.org/c/coreboot/+/30987/42/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/42/src/mainboard/asus/a88xm-e... PS42, Line 163: /* TODO: is this OK for DDR3 socket FM2? */ : /* : MEMCLK_DIS_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), : CKE_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x05, 0x0A), : ODT_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x00, 0x00), : CS_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), : */
You can also rewrite AGESA and add support for XMP memory profiles. […]
XMP support has been successfully added to opensource AGESA ;-) Please see the topic:"AMD_XMP" changes: CB:40484 , CB:40485 , CB:40488 , CB:40489 , CB:40490 .
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/OemCustomize.c:
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 147: * CUSTOMER OVERIDES MEMORY TABLE
Please fix.
Done.
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/acpi/cpstate.asl:
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 16: /* This
This comment should start like this: […]
Done.
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 20: */
Needs a space
Done.
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/mptable.c:
PS47:
Is this even correct?
Didn't understand the question...
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 125: Lan
LAN (and add a space after it)
Done.