Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36835 )
Change subject: Drop hard coded SPI flash size in firmware.c
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/em100/+/36835/1/firmware.c
File firmware.c:
https://review.coreboot.org/c/em100/+/36835/1/firmware.c@89
PS1, Line 89: (2*1024*1024);
no need for the parens here, and since we'll have a bunch of these, maybe #define MB 1024*1024, so i […]
Done
https://review.coreboot.org/c/em100/+/36835/1/firmware.c@95
PS1, Line 95: data = malloc(rom_size);
malloc without free
Done
--
To view, visit
https://review.coreboot.org/c/em100/+/36835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Id6851ab5017dc63ed16b5c289c17ff4ea5323d8f
Gerrit-Change-Number: 36835
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Nov 2019 21:58:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment