[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Add logo support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37515 )

Change subject: drivers/intel/fsp2_0: Add logo support
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 3:
>
> (1 comment)

https://review.coreboot.org/c/coreboot/+/37515/3/src/drivers/intel/fsp2_0/si... 
File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37515/3/src/drivers/intel/fsp2_0/si... 
PS3, Line 61: if (CONFIG(FSP2_0_DISPLAY_LOGO)) {
            : 		upd->FspsConfig.LogoSize = 1 * MiB;
            : 		logo_entry = cbmem_entry_add(CBMEM_ID_FSP_LOGO, upd->FspsConfig.LogoSize);
            : 		upd->FspsConfig.LogoPtr = (UINT32)cbmem_entry_start(logo_entry);
            : 		load_logo(upd);
            : 	}
> I just saw this patch. I realized that LogoSize and LogoPtr are platform/SoC specific UPDs. […]

Agree specific UPDs should be handled in SoC.