Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43088 )
Change subject: tests: Add lib/hexstrtobin-test test case ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43088/2/tests/lib/hexstrtobin-test.... File tests/lib/hexstrtobin-test.c:
https://review.coreboot.org/c/coreboot/+/43088/2/tests/lib/hexstrtobin-test.... PS2, Line 11: int val[2]; This should not be hard-coded, because it restricts the test cases you can have. Also, if the size is hard-coded, then using `res` to say how many bytes are in the result is redundant.
https://review.coreboot.org/c/coreboot/+/43088/2/tests/lib/hexstrtobin-test.... PS2, Line 14: {"277a", {39, 122}, 2}, Add more test cases, such as two hex digits, an odd number of hex digits with non-hex values, and a case where there is only one hex digit, and so there is no result.