Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35397 )
Change subject: ec/acpi: Replace __PRE_RAM__ use
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35397/1/src/ec/acpi/ec.c
File src/ec/acpi/ec.c:
https://review.coreboot.org/c/coreboot/+/35397/1/src/ec/acpi/ec.c@159
PS1, Line 159: ENV_STAGE_HAS_DATA_SECTION
Do you think we should add a data section? Or continue on as needed.
I think .data would help with CB:34929 to declare unlocked spinlocks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35397
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae31569f16168ba00ce272e4777f3a69bcd6ee94
Gerrit-Change-Number: 35397
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Sep 2019 19:33:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment