Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/...
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/...
PS10, Line 26: device ref sata on end
I remember that is HW compatible? Volteer has SATA, I can remove this if we have no plan to support […]
Eh, we can turn it off later too, I don't think we were going to use SATA, but that could still change too I suppose.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia94119cb6d7eff6ea13c7d6a7dfd6ce891f706fd
Gerrit-Change-Number: 48139
Gerrit-PatchSet: 10
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 02 Dec 2020 04:29:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment