Attention is currently required from: Jakub Czapiga, Jérémy Compostella, Werner Zeh.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79946?usp=email )
Change subject: [RFC] region: Turn region_end() into an inclusive region_last()
......................................................................
Patch Set 5:
(1 comment)
File src/drivers/spi/winbond.c:
https://review.coreboot.org/c/coreboot/+/79946/comment/755e9a54_8c3fbe1a :
PS5, Line 505: region_last(region) + 1
Could this possibly lead to an overflow again?
Yes, it would be better to use `flash->size - 1`. I guess we shouldn't
expect regions bigger than a flash, but better safe than sorry.
OTOH, (just read the code again), it would need a 4GiB flash to make
a difference :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79946?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4bd6eced638745b7e845504da74542e4220554a
Gerrit-Change-Number: 79946
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Mon, 15 Jan 2024 17:25:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment