Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: src/arch: This is an upgrade of SMBIOS to latest version 3.2 ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@279 PS1, Line 279: t->clock_speed = dimm->ddr_frequency; clock_speed and speed are now in units of MT/s instead of Mhz. Please update all callers that provide the value in Mhz.
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@331 PS1, Line 331: t->memory_technology = MEMORY_TECHNOLOGY_UNKNOWN; likely DRAM
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@561 PS1, Line 561: u16 __weak smbios_processor_core_thread_count(u16 level_type) why it it __weak?
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@824 PS1, Line 824: se->major_version = 2; update to 3
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@825 PS1, Line 825: se->minor_version = 7; update to 2
https://review.coreboot.org/#/c/32090/1/src/arch/x86/smbios.c@829 PS1, Line 829: add the 64bit entry point as specified in SMBIOS 3.0. It has an anchor "_SM3_"