Attention is currently required from: Keith Hui.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76963?usp=email )
Change subject: mb/samsung/lumpy: Clean up MRC PEI data ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/samsung/lumpy/early_init.c:
https://review.coreboot.org/c/coreboot/+/76963/comment/d688a821_a59611db : PS1, Line 118: uint8_t spdaddr[] = {0xa0, 0x00, 0x00, 0x00}; : uint8_t tsaddr[] = { 0x30, 0x00, 0x00, 0x00}; : uint16_t usbcfg[16][3] = { I won't comment on the rest of the patches, but I think these data structures should be marked as const on all of them.
https://review.coreboot.org/c/coreboot/+/76963/comment/8414788c_68cd63e4 : PS1, Line 137: pei_data->system_type = 0; // 0 Mobile, 1 Desktop/Server How did you determine what is needed for each platform? On the last patch for the lenovo x220, this line was not added. Why is it needed here, but not there?
How can you verify that all of the data is the same after the patch as it was before?