Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39004 )
Change subject: drivers: Replace set_vbe_mode_info_valid ......................................................................
Patch Set 30: Code-Review+1
(1 comment)
Marked one more low hanging fruit. Ideally, we'd get rid of all framebuffer infos inside `struct edid`. If somebody wants to tackle that? Most of the left _edid cases only write the info into `struct edid` to pass it to fb_new_framebuffer_ info_from_edid(). But that's for another patch.
https://review.coreboot.org/c/coreboot/+/39004/30/src/soc/nvidia/tegra124/di... File src/soc/nvidia/tegra124/display.c:
https://review.coreboot.org/c/coreboot/+/39004/30/src/soc/nvidia/tegra124/di... PS30, Line 316: struct edid edid; : edid.mode.va = config->yres; : edid.mode.ha = config->xres; : edid_set_framebuffer_bits_per_pixel(&edid, : config->framebuffer_bits_per_pixel, 32); : fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)(framebuffer_base_mb*MiB)); This looks like another case for fb_add_framebuffer_info().