Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32076 )
Change subject: mb/protectli/vault: Add FW2B and FW4B boards support
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/32076/14/Documentation/mainboard/pr...
File Documentation/mainboard/protectli/fw2b_fw4b.md:
https://review.coreboot.org/c/coreboot/+/32076/14/Documentation/mainboard/pr...
PS14, Line 83: - mPCIe debug card connected to mSATA (mSATA slot has LPC signals routed,
The LPC pinout has to match that of the debug card
Compared the pinout of FW6 (where LPC card works) with the schematics of FW2B/FW4B. The routes are exactly the same. I don't have the debug card pinout/schematics so I am not sure this is the issue...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I553fd3a89299314a855f055014ca7645100e12e7
Gerrit-Change-Number: 32076
Gerrit-PatchSet: 14
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 11:43:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment