Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37874 )
Change subject: soc/intel/cannonlake: Add VR config for CML ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37874/5/src/soc/intel/cannonlake/ch... File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37874/5/src/soc/intel/cannonlake/ch... PS5, Line 226: performance Should performance be the default if cpu_pl2_4_cfg is not explicitly set?
https://review.coreboot.org/c/coreboot/+/37874/5/src/soc/intel/cannonlake/vr... File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/37874/5/src/soc/intel/cannonlake/vr... PS5, Line 406: VR_CFG_ALL_DOMAINS_LOADLINE(10.3, 1.1, 4.0, 4.0); : if (tdp <= 35) : loadline[VR_IA_CORE] = VR_CFG_MOHMS(1.7); nit: All the other comparisons in this file are "if (tdp >= ...)". Could you change this one too?