Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: ec/kontron: Fix control flow DEADCODE issue ......................................................................
Patch Set 8:
Patch Set 8: Code-Review-1
I strongly advice against using assert() like this. If we know, event want, that the check is done at build time, we should use _Static_assertion(). Beside being clear to the reader it also allows us to specify a proper error message.
Do we even know if using assert() (which only does the build- time check with our custom implementation) will calm Coverity? iow. is it smart enough to detect that this is no usual assert()?
There's CB:44476 which would probably not work if using a _Static_assert().