Hello build bot (Jenkins), Mariusz Szafrański, Maulik V Vaghela, Sugnan Prabhu S, Angel Pons, Krishna P Bhat D, Andrey Petrov, Aaron Durbin, Patrick Rudolph, Jason Glenesk, Marshall Dawson, Caveh Jalali, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Furquan Shaikh, Lean Sheng Tan, Ronak Kanabar, Michal Motyl, Srinidhi N Kaushik, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48174
to look at the new patch set (#8).
Change subject: drivers/intel/fsp2_0: Fix running on x86_64 ......................................................................
drivers/intel/fsp2_0: Fix running on x86_64
Add new Kconfig symbols to mark FSP binary as x86_32. Fix the FSP headers and replace void pointers by fixed sized integers depending on the used mode to compile the FSP. This is necessary to run on x86_64, as pointers have different size.
Add preprocessor error to warn that x86_64 FSP isn't supported by the current code.
Tested on Intel Skylake. FSP-M no longer returns the error "Invalid Parameter".
Change-Id: I6015005c4ee3fc2f361985cf8cff896bcefd04fb Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/header_display.c M src/drivers/intel/fsp2_0/include/fsp/info_header.h M src/drivers/intel/fsp2_0/include/fsp/upd.h M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/intel/fsp2_0/notify.c M src/drivers/intel/fsp2_0/silicon_init.c M src/mainboard/google/hatch/romstage_spd_smbus.c M src/soc/amd/picasso/romstage.c M src/soc/intel/quark/romstage/fsp_params.c M src/vendorcode/amd/fsp/picasso/fsp_h_c99.h M src/vendorcode/intel/edk2/UDK2015/IntelFsp2Pkg/Include/FspEas/FspApi.h M src/vendorcode/intel/edk2/UDK2017/IntelFsp2Pkg/Include/FspEas/FspApi.h M src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include/FspEas/FspApi.h 14 files changed, 81 insertions(+), 47 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/48174/8