Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31511 )
Change subject: AGESA: Move heap_status_name() implementation ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
(1 comment)
Any idea why Proc/CPU/Family was also being included? Removing it seems unrelated
Well git blame says it was my line, so I would say it did not build without.
https://review.coreboot.org/#/c/31511/2/src/vendorcode/amd/agesa/common/debu... File src/vendorcode/amd/agesa/common/debug_util.c:
https://review.coreboot.org/#/c/31511/2/src/vendorcode/amd/agesa/common/debu... PS2, Line 2: #include <AGESA.
I'm not seeing why this is necessary. (Also, BTW I believe in all cases where you include AGESA.h, you also pick up AMD.h.)
It's still a big mess with the headers and includes in general, e.g. that one __packed is still to be fixed for AGESA and/or binaryPI.