Patch Set 3:

(1 comment)

Any idea why Proc/CPU/Family was also being included? Removing it seems unrelated

Well git blame says it was my line, so I would say it did not build without.

View Change

1 comment:

• File src/vendorcode/amd/agesa/common/debug_util.c:

  • Patch Set #2, Line 2: #include <AGESA.

    I'm not seeing why this is necessary. (Also, BTW I believe in all cases where you include AGESA.h, you also pick up AMD.h.)

    It's still a big mess with the headers and includes in general, e.g. that one __packed is still to be fixed for AGESA and/or binaryPI.

To view, visit change 31511. To unsubscribe, or for help writing mail filters, visit settings.