Barnali Sarkar has posted comments on this change. ( https://review.coreboot.org/19023 )
Change subject: KBL: Update FSP headers - upgrade to FSP.2.0.0 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/19023/2/src/vendorcode/intel/fsp/fsp2_0/skyk... File src/vendorcode/intel/fsp/fsp2_0/skykabylake/ConfigBlock/CpuConfigFspData.h:
Line 69: There is no change here actually.
https://review.coreboot.org/#/c/19023/2/src/vendorcode/intel/fsp/fsp2_0/skyk... File src/vendorcode/intel/fsp/fsp2_0/skykabylake/MemInfoHob.h:
PS2, Line 206: EFI_HOB_GUID_TYPE EfiHobGuidType This parameter should be skipped. FSP should only publish the Raw data of the HOB, it should not include the HOB Header.