Hello build bot (Jenkins), Lijian Zhao, Jamie Chen, Patrick Rudolph, Maulik V Vaghela, Duncan Laurie, John Zhao, Aamir Bohra, Kane Chen, Patrick Rudolph, Praveen Hodagatta pranesh, Nate DeSimone, Rizwan Qureshi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39454
to look at the new patch set (#13).
Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD ......................................................................
soc/intel/cannonlake: Steal no memory for disabled IGD
Set IgdDvmt50PreAlloc to zero if InternalGfx is disabled. It is 'correct' to do it like this, otherwise the FSP would always allocate memory for the IGD even if it is disabled. In addition the FSP enables the graphics panel even if no IGD is present which leads to a crashing FSP. Thus, if no IGD is present we switch of the panel via UPDs.
Also apply a workaround to prevent a crash, see https://github.com/IntelFsp/FSP/issues/49 for details.
Tested on: * CFL platform with IGD * CFL platform without IGD
Change-Id: I6f9e0f9855224614471d8ed23bf2a9786386ddca Signed-off-by: Christian Walter christian.walter@9elements.com --- M Documentation/soc/intel/fsp/index.md M src/soc/intel/cannonlake/romstage/fsp_params.c 2 files changed, 27 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/39454/13