Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41719/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41719/5//COMMIT_MSG@11 PS5, Line 11:
Yes, please add a note to the commit message though, what it’s too much work.
Done. Added a note to the commit message.
https://review.coreboot.org/c/coreboot/+/41719/1/src/soc/amd/picasso/microco... File src/soc/amd/picasso/microcode_picasso.c:
https://review.coreboot.org/c/coreboot/+/41719/1/src/soc/amd/picasso/microco... PS1, Line 106: uint32_t equivalent_processor_rev_id
It is hard to explain. It is explained in Revision Guide.
Please review the revision guide.
https://review.coreboot.org/c/coreboot/+/41719/1/src/soc/amd/picasso/update_... File src/soc/amd/picasso/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/41719/1/src/soc/amd/picasso/update_... PS1, Line 23: /* Array terminator */ : { 0xffffff, 0x0000 },
If the code is more readable that way, then yes. […]
Done. Changed to ARRAY_SIZE