8 Sep
2020
8 Sep
'20
4:55 a.m.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43410 )
Change subject: mb/51nb/x210/gpio: 4/4 Convert field macros to PAD_CFG ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43410/5/src/mainboard/51nb/x210/gpi... File src/mainboard/51nb/x210/gpio.h:
https://review.coreboot.org/c/coreboot/+/43410/5/src/mainboard/51nb/x210/gpi... PS5, Line 131: PAD_CFG_GPIO_BIDIRECT
What do you think about this? CB:42914
added to gpio.h in the latest patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/43410
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18c0c321561eee04ff927681b0a231f6d79c63e2
Gerrit-Change-Number: 43410
Gerrit-PatchSet: 13
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Sep 2020 10:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-MessageType: comment