Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31943 )
Change subject: vboot: deprecate physical dev switch ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patch Set 1:
(2 comments)
I don't know the details, I thought virtual dev switch depended on chrome-ec.
Thanks for pointing out that GPIO code.
Virtual dev switch depends on being able to enter recovery mode. The process for entering recovery mode depends on the particular device -- for most, a keyboard combination is used (Esc+Refresh+Power) which indeed depends on Chrome EC. For others, a physical recovery mode button is used, which does not require Chrome EC.
https://review.coreboot.org/#/c/31943/1/src/mainboard/samsung/stumpy/chromeo... File src/mainboard/samsung/stumpy/chromeos.c:
https://review.coreboot.org/#/c/31943/1/src/mainboard/samsung/stumpy/chromeo... PS1, Line 132:
Do you want to keep this?
Done
https://review.coreboot.org/#/c/31943/1/src/mainboard/samsung/stumpy/chromeo... PS1, Line 139:
This probably keeps switch advertised in ACPI ?
Done