build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48537 )
Change subject: soc/amd/picasso: move chipset_handle_reset to common
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48537/1/src/soc/amd/common/fsp/fsp_...
File src/soc/amd/common/fsp/fsp_reset.c:
https://review.coreboot.org/c/coreboot/+/48537/1/src/soc/amd/common/fsp/fsp_...
PS1, Line 13: BUG();
Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48537
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15f2622d9d9d0f22e3cf8e6283b578f5933b1a9f
Gerrit-Change-Number: 48537
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 17:07:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment